Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr: use ipv4 default when ipv6 was disabled #29194

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@pdvian
Copy link

commented Jul 23, 2019

kungf Prashant D
mgr: use ipv4 default when ipv6 was disabled
Fixes: https://tracker.ceph.com/issues/40023
Signed-off-by: kungf <yang.wang@easystack.cn>
(cherry picked from commit 38e7083)

@smithfarm smithfarm requested review from epuertat, votdev and jan--f Jul 23, 2019

@smithfarm smithfarm added this to the nautilus milestone Jul 23, 2019

@jan--f
jan--f approved these changes Jul 23, 2019
@votdev

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

For backports you need to cherry pick the changes from the origin PR, in this case 748c294, otherwise @smithfarm won't be happy. Please have a look at http://docs.ceph.com/docs/master/dev/developer_guide/#backporting or #29050 (comment).

@smithfarm
Copy link
Contributor

left a comment

Backport of #28246 containing one commit which applies cleanly to nautilus.

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@votdev Not sure why you're suggesting to cherry-pick the merge commit?

This backport PR looks fine to me.

@smithfarm smithfarm requested a review from tchaikov Jul 23, 2019

@votdev

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@votdev Not sure why you're suggesting to cherry-pick the merge commit?

This backport PR looks fine to me.

Uahh, sorry, it should be 38e7083

@votdev
votdev approved these changes Jul 24, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@yuriw yuriw merged commit 4e2a5e7 into ceph:nautilus Jul 30, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.