Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: tools: Add clear-data-digest command to objectstore tool #29196

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 23, 2019

@smithfarm smithfarm self-assigned this Jul 23, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 23, 2019
@smithfarm smithfarm requested a review from dzafman Jul 23, 2019
@smithfarm smithfarm changed the title mimic: Add clear-data-digest command to objectstore tool mimic: tools: Add clear-data-digest command to objectstore tool Jul 23, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 23, 2019

/home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/ceph_objectstore_tool.cc: In function 'int clear_data_digest(ObjectStore*, coll_t, ghobject_t&)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/ceph_objectstore_tool.cc:2671:18: error: 'using bufferlist = class ceph::buffer::list' {aka 'class ceph::buffer::list'} has no member named 'cbegin'; did you mean 'begin'?
   auto bp = attr.cbegin();
                  ^~~~~~
                  begin
There may be a situation where data digest in object info is
inconsistent with that computed from object data, then deep-scrub
will fail even though all three repicas have the same object data.

Fixes: https://tracker.ceph.com/issues/37935

Signed-off-by: Li Yichao <liyichao.good@gmail.com>
(cherry picked from commit da5832b)

Conflicts:
    src/tools/ceph_objectstore_tool.cc
- change cbegin() to begin() to get it to build
@smithfarm smithfarm force-pushed the smithfarm:wip-37749-mimic branch from 3cf8dc8 to 7835db6 Jul 23, 2019
@smithfarm smithfarm requested a review from neha-ojha Jul 23, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 23, 2019

Copy link
Member

dzafman left a comment

Make sure this passes:

../qa/run-standalone.sh ceph_objectstore_tool.py

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 23, 2019

@dzafman I'm not sure if @yuriw runs that suite. I can try to run it, though.

@yuriw yuriw merged commit 5343911 into ceph:mimic Jul 24, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-37749-mimic branch Jul 25, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 25, 2019

@dzafman I ran it on the tip of mimic (which now includes this PR) and it passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.