Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: mgr: DaemonServer::handle_conf_change - broken locking #29197
The is_locked_by_me() is only meant to be safe if you know you hold the lock. It's meant to be used in an assertion. Fixes: http://tracker.ceph.com/issues/38899 Signed-off-by: xie xingguo <firstname.lastname@example.org> (cherry picked from commit a929a5a) Conflicts: src/mgr/DaemonServer.cc - use Mutex::Locker instead of std::lock_guard
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.