Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upmimic: cephfs: ceph-fuse: client hang because its bad session PipeConnection to mds #29200
+16
−14
Conversation
to mds. There still has a risk client will hang all the time and which happened in my enviroment a few days ago. Well konw, the start of mds will go through four stages at least(replay, reconnect, rejoin, active). According to current logic, we recived replay mdsmap and marked down pipe will return directly and if we miss the next reconnect mdsmap the client may hang all the time becuase we lost the opportunity due to old_inc equal to new_inc. So we shuold judge if we have lost MDSMap::reconnect by comparing newstate and oldstate. Fixes: http://tracker.ceph.com/issues/39305 Signed-off-by: Guan yunfei <yunfei.guan@xtaotech.com> (cherry picked from commit 51c9f5c) Conflicts: src/client/Client.cc - mimic has "kick_maxsize_requests(session); wake_inode_waiters(session);" where master has just "wake_up_session_caps(session, true)
smithfarm
changed the title
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
smithfarm commentedJul 23, 2019
http://tracker.ceph.com/issues/39685