Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/influx: module fails due to missing close() method #29207

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@smithfarm
Copy link
Contributor

commented Jul 23, 2019

mgr/influx: try to call close()
let's at least try to call influxclient.close() which in turn closes the
requests.Session

see
https://github.com/influxdata/influxdb-python/blob/v4.1.1/influxdb/client.py
and
https://github.com/influxdata/influxdb-python/blob/v5.0.0/influxdb/client.py

Fixes: http://tracker.ceph.com/issues/40174
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8066a55)

@smithfarm smithfarm self-assigned this Jul 23, 2019

@smithfarm smithfarm added this to the nautilus milestone Jul 23, 2019

@smithfarm smithfarm changed the title nautilus: Influx module fails due to missing close() method nautilus: mgr/influx: module fails due to missing close() method Jul 23, 2019

@smithfarm smithfarm requested a review from tchaikov Jul 23, 2019

@smithfarm smithfarm added mgr and removed core labels Jul 23, 2019

@wido
wido approved these changes Jul 24, 2019
Copy link
Member

left a comment

LGTM

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@yuriw yuriw merged commit 7ad4a3a into ceph:nautilus Jul 30, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-40904-nautilus branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.