Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: bluestore: _txc_add_transaction error (39) Directory not empty not handled on operation 21 (op 1, counting from 0) #29217

Merged
merged 3 commits into from Jul 30, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 23, 2019

liewegas added 3 commits Jul 18, 2019
If an object has an empty 'name' field, it "looks" like a pgmeta object,
and the PG cleanup code was skipping it.  However, we were letting these
objects get created.

Fix by only skipping *our* pgmeta object.  If there are other pgmeta-like
objects in the PG collection, clean them up.

Fixes: https://tracker.ceph.com/issues/38724
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a0f48db)

# Conflicts:
#	src/osd/PG.cc
- location of this code is do_delete_work in master, _delete_some in n
These may conflict with pgmeta objects.  And are going to cause other
problems later (e.g., https://tracker.ceph.com/issues/38724).

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit bf6e8a4)
This is always a bug (OSD doesn't try to remove a collection unless it
thinks it is empty), and not seeing it at default debug levels makes it
hard to track down.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit e387cbc)

Conflicts:
	src/os/bluestore/BlueStore.cc
- mimic does not have 87e8231
@smithfarm smithfarm self-assigned this Jul 23, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 23, 2019
@smithfarm smithfarm added bug fix core bluestore and removed core labels Jul 23, 2019
@smithfarm smithfarm requested review from ifed01 and liewegas Jul 23, 2019
@smithfarm smithfarm changed the title mimic: _txc_add_transaction error (39) Directory not empty not handled on operation 21 (op 1, counting from 0) mimic: bluestore: _txc_add_transaction error (39) Directory not empty not handled on operation 21 (op 1, counting from 0) Jul 23, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 23, 2019

@ifed01
ifed01 approved these changes Jul 24, 2019
@yuriw yuriw merged commit 8568dc2 into ceph:mimic Jul 30, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-39692-mimic branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.