Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mds: there is an assertion when calling Beacon::shutdown() #29223

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 23, 2019

If you run MDSDaemon::init(), an exception occurs that causes MDSDaemon::suicide()--->Beacon::shutdown()--->sender.join();
this problem occurs because sender is just Default-constructed is in Beacon.h(std::thread sender;), there is no call
to Beacon::init() to construct the sender, so the sender has no "joinable"

Fixes: http://tracker.ceph.com/issues/38822
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
(cherry picked from commit 526bbda)
@smithfarm smithfarm self-assigned this Jul 23, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 23, 2019
@smithfarm smithfarm added bug fix core cephfs and removed core labels Jul 23, 2019
@smithfarm smithfarm requested a review from batrick Jul 23, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Aug 7, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 15, 2019

@yuriw yuriw merged commit 67cfb54 into ceph:mimic Oct 17, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-39215-mimic branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.