Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: cephfs: mount: key parsing fail when doing a remount #29225

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 23, 2019

When doing a CephFS remount (-o remount) the secret is parsed from procfs
and we get '<hidden>' as a result and the mount will fail with:

  secret is not valid base64: Invalid argument.
  adding ceph secret key to kernel failed: Invalid argument.

As the kernel already have the key, we simply need to use it.

Fixes: https://tracker.ceph.com/issues/39951
Signed-off-by: Luis Henriques <lhenriques@suse.com>
(cherry picked from commit f44516b)
@smithfarm smithfarm self-assigned this Jul 23, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 23, 2019
@smithfarm smithfarm added bug fix core cephfs and removed core labels Jul 23, 2019
@smithfarm smithfarm requested a review from batrick Jul 23, 2019
@smithfarm smithfarm changed the title mimic: mount: key parsing fail when doing a remount mimic: cephfs: mount: key parsing fail when doing a remount Jul 23, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 23, 2019

jenkins test docs

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Aug 7, 2019

@batrick
batrick approved these changes Oct 7, 2019
batrick added a commit that referenced this pull request Oct 7, 2019
* refs/pull/29225/head:
	common/secret.c: fix key parsing when doing a remount

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick batrick merged commit 8b8ae6c into ceph:mimic Oct 7, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40165-mimic branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.