Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mds: cannot switch mds state from standby-replay to active #29232

Merged
merged 2 commits into from Oct 17, 2019

Conversation

Fixes:http://tracker.ceph.com/issues/40213
Signed-off-by: simon gao <simon29rock@gmail.com>

(cherry picked from commit c0fe25b)

Conflicts:
	src/mds/MDCache.cc
- mimic doesn't have the "throttled" stuff
@smithfarm smithfarm self-assigned this Jul 23, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 23, 2019
@smithfarm smithfarm added bug fix core cephfs and removed core labels Jul 23, 2019
@smithfarm smithfarm requested review from batrick and ukernel Jul 23, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Aug 7, 2019

Standby replay mds first trims expired log segments, then replays new
log segments. It's possible a 'truncate_start' log event is in expired,
but its 'truncate_finish' counterpart is the new log segments. When mds
replays the 'truncate_finish' log event, log segment that contains the
'truncate_start' is already trimmed, so mds does nothing. This causes
leak of Inode::PIN_TRUNCATING and trigger assertion when removing
corresponding inode.

Fixes: https://tracker.ceph.com/issues/40477
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 3212187)
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 7, 2019

@ukernel Please take another look - I cherry-picked another patch into the PR.

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 13, 2019

@yuriw yuriw merged commit 6d985a4 into ceph:mimic Oct 17, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40439-mimic branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.