Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: crc cache should be invalidated when posting preallocated rx buffers #29247

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 24, 2019

@smithfarm smithfarm self-assigned this Jul 24, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 24, 2019
@smithfarm smithfarm requested a review from idryomov Jul 24, 2019
@smithfarm smithfarm changed the title mimic: crc cache should be invalidated when posting preallocated rx buffers mimic: core: crc cache should be invalidated when posting preallocated rx buffers Jul 24, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 24, 2019

I'll wait for review since this backport omits the test.

Copy link
Contributor

idryomov left a comment

It was mostly a rename from src/test/librados/io.cc to src/test/librados/io_cxx.cc. I think it should apply cleanly and work if you simply rename the test file in the patch.

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Aug 28, 2019

@idryomov Thanks - the rename was done by 3730d10 which is not being backported to mimic, but I'll manually cherry-pick the test mods into src/test/librados/io.cc

Both simple and async messengers use c_str() when copying the data from
the socket into the receive buffer, going behind bufferlist's back.  If
the receive buffer is preallocated, we need to invalidate its crc cache
by hand to avoid possible data crc mismatches on the client side.

Fixes: https://tracker.ceph.com/issues/38416
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 3eeab97)

Conflicts:
	src/test/librados/io_cxx.cc
- In master, 3730d10 renamed this file from
  src/test/librados/io.cc but that commit is not being backported to mimic.
  Manually cherry-picked the test mods into src/test/librados/io.cc.
@smithfarm smithfarm force-pushed the smithfarm:wip-38437-mimic branch from 40c2d01 to d441e99 Aug 28, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Aug 28, 2019

jenkins test docs

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Sep 30, 2019

@yuriw yuriw merged commit 13030c9 into ceph:mimic Oct 3, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-38437-mimic branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.