Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: multisite: 'radosgw-admin bucket sync status' should call syncs_from(source.name) instead of id #29270

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 24, 2019

If a zone is set up with sync_from_all=false, the bucket sync status
command will incorrectly report "not in sync_from" because it's calling
'zone.syncs_from(source.id)', where syncs_from() expects a zone name
instead of id

Fixes: http://tracker.ceph.com/issues/40022

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 9da8886)

Conflicts:
	src/rgw/rgw_zone.h
- in mimic, this code is in src/rgw/rgw_rados.h - made the change there instead
@smithfarm smithfarm self-assigned this Jul 24, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 24, 2019
@smithfarm smithfarm changed the title mimic: multisite: 'radosgw-admin bucket sync status' should call syncs_from(source.name) instead of id mimic: rgw: multisite: 'radosgw-admin bucket sync status' should call syncs_from(source.name) instead of id Jul 24, 2019
@smithfarm smithfarm requested a review from cbodley Jul 24, 2019
@smithfarm smithfarm added rgw and removed core labels Jul 24, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 24, 2019

Err:1 http://nova.clouds.archive.ubuntu.com/ubuntu xenial/main amd64 bc amd64 1.06.95-9build1
  Something wicked happened resolving 'nova.clouds.archive.ubuntu.com:http' (-5 - No address associated with hostname)
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 24, 2019

jenkins test make check

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Aug 5, 2019

@cbodley
cbodley approved these changes Aug 6, 2019
@yuriw yuriw merged commit 476f4ca into ceph:mimic Aug 6, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40141-mimic branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.