Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: Multisite sync corruption for large multipart obj #29273

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 24, 2019

cbodley and others added 2 commits May 29, 2019
if the size of object data received doesn't match the value returned in
the Rgwx-Object-Size header, fail with -EIO

Fixes: https://tracker.ceph.com/issues/39992

Signed-off-by: Xiaoxi CHEN <xiaoxchen@ebay.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit c6c4c56)
if meet tcp packet loss, curl return will be result=18(CURLE_PARTIAL_FILE)
and http_status=200, so sync will continue and cause content miss match.

Fixes: https://tracker.ceph.com/issues/39992

Signed-off-by: Tianshan Qu <tianshan@xsky.com>
(cherry picked from commit 9b70258)
@smithfarm smithfarm self-assigned this Jul 24, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 24, 2019
@smithfarm smithfarm changed the title mimic: Multisite sync corruption for large multipart obj mimic: rgw: Multisite sync corruption for large multipart obj Jul 24, 2019
@smithfarm smithfarm requested a review from cbodley Jul 24, 2019
@smithfarm smithfarm added rgw and removed core labels Jul 24, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 24, 2019

In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/include/gtest/gtest.h:1874,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_http_manager.cc:22:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_http_manager.cc: In member function 'virtual void HTTPManager_ReadTruncated_Test::TestBody()':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_http_manager.cc:47:48: error: 'null_yield' was not declared in this scope
   EXPECT_EQ(-EAGAIN, RGWHTTP::process(&client, null_yield));
                                                ^~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_http_manager.cc:47:48: note: suggested alternative: 'nullKey'
src/test/rgw/CMakeFiles/unittest_http_manager.dir/build.make:62: recipe for target 'src/test/rgw/CMakeFiles/unittest_http_manager.dir/test_http_manager.cc.o' failed
make[3]: *** [src/test/rgw/CMakeFiles/unittest_http_manager.dir/test_http_manager.cc.o] Error 1
@smithfarm smithfarm force-pushed the smithfarm:wip-40144-mimic branch from 3b88990 to 9029871 Jul 24, 2019
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit c669cf2)

Conflicts:
    src/test/rgw/test_http_manager.cc
- RGWHTTP::process() only takes one argument in mimic
@smithfarm smithfarm force-pushed the smithfarm:wip-40144-mimic branch from 9029871 to 073fa91 Jul 24, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Aug 5, 2019

@cbodley
cbodley approved these changes Aug 6, 2019
@yuriw yuriw merged commit 9e56c6a into ceph:mimic Aug 6, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40144-mimic branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.