Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw_file: include tenant when hashing bucket names #29277

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 24, 2019

Prevent identical paths from distinct tenants from colliding in
RGW NFS handle cache.

Fixes: http://tracker.ceph.com/issues/40118

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit b800a9d)

Conflicts:
	src/rgw/rgw_file.cc
- ceph_assert
Because bucket names are taken as object names in the top
of an export.  Make hashing by tenant general to avoid disjoint
hashing of bucket.

Fixes: http://tracker.ceph.com/issues/40118

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 8e0fd5f)
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 84a2c22)
@smithfarm smithfarm self-assigned this Jul 24, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 24, 2019
@smithfarm smithfarm requested review from cbodley and mattbenjamin Jul 24, 2019
@smithfarm smithfarm added rgw and removed core labels Jul 24, 2019
Copy link
Contributor

mattbenjamin left a comment

lgtm

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Aug 5, 2019

@yuriw yuriw merged commit c495f2d into ceph:mimic Aug 6, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40225-mimic branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.