Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw/OutputDataSocket: append_output(buffer::list&) says it will (but does not) discard output at data_max_backlog #29279

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 24, 2019

A dout message in OutputDataSocket::append_output() states that
data will be dropped when appending would cause data_max_backlog
to be exceeded--but the method appends it anyway.

Log output discards at level 0, as messages will be lost.  Suppress
repeated warnings mod 100.  Switch to vector.

Fixes: http://tracker.ceph.com/issues/40178

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit c806b82)

Conflicts:
	src/common/OutputDataSocket.cc
	src/common/OutputDataSocket.h
@smithfarm smithfarm self-assigned this Jul 24, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 24, 2019
@smithfarm smithfarm requested review from mattbenjamin and cbodley Jul 24, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Aug 5, 2019

@cbodley
cbodley approved these changes Aug 6, 2019
@yuriw yuriw merged commit a4c190e into ceph:mimic Aug 6, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40351-mimic branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.