Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: rgw/OutputDataSocket: append_output(buffer::list&) says it will (but does not) discard output at data_max_backlog #29279
A dout message in OutputDataSocket::append_output() states that data will be dropped when appending would cause data_max_backlog to be exceeded--but the method appends it anyway. Log output discards at level 0, as messages will be lost. Suppress repeated warnings mod 100. Switch to vector. Fixes: http://tracker.ceph.com/issues/40178 Signed-off-by: Matt Benjamin <firstname.lastname@example.org> (cherry picked from commit c806b82) Conflicts: src/common/OutputDataSocket.cc src/common/OutputDataSocket.h
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.