Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw: set null version object issues #29287

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@smithfarm
Copy link
Contributor

commented Jul 24, 2019

rgw: set null version object acl issues
1.set null version object acl will create empty index
RGWRados::set_attrs did not clear instance, so index prepare, complete got instance=null,
which lead to empty index 1000_<obj>_i_null.
there is no harm to create empty index, but listomapkeys to find that key.

2.if object is exist with versioned key, we can set none exists null version object
order:
1) enable bucket version
2) put obj
3) disable bucket version
4) set versoned_id=null acl will succeed which should not

Fixes: http://tracker.ceph.com/issues/36763

Signed-off-by: Tianshan Qu <tianshan@xsky.com>
(cherry picked from commit ca6e5c8)

@smithfarm smithfarm self-assigned this Jul 24, 2019

@smithfarm smithfarm added this to the nautilus milestone Jul 24, 2019

@smithfarm smithfarm added bug fix core rgw and removed core labels Jul 24, 2019

@smithfarm smithfarm requested a review from cbodley Jul 24, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@yuriw yuriw merged commit f6bf1a3 into ceph:nautilus Jul 30, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-40358-nautilus branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.