Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rbd/action: fix error getting positional argument #29294

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@dillaman
Copy link
Contributor

dillaman commented Jul 24, 2019

Fixes: http://tracker.ceph.com/issues/40095

Signed-off-by: songweibin <song.weibin@zte.com.cn>
(cherry picked from commit 32a044b)

Conflicts:
	src/tools/rbd/action/Config.cc: DNE in Mimic
@dillaman dillaman added this to the mimic milestone Jul 24, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jul 25, 2019

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/cli/rbd/help.t: passed
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/cli/rbd/invalid-snap-usage.t: passed
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/cli/rbd/not-enough-args.t: failed
--- /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/cli/rbd/not-enough-args.t
+++ /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/cli/rbd/not-enough-args.t.err
@@ -107,8 +107,12 @@
   rbd: metadata key was not specified
   [22]
   $ rbd image-meta set foo key
-  rbd: metadata value was not specified
-  [22]
+  unable to get monitor info from DNS SRV with service name: ceph-mon
+  no monitors specified to connect to.
+  rbd: couldn't connect to the cluster!
+  2019-07-24 22:28:35.690 7f21573fcb40 -1 failed for service _ceph-mon._tcp
+  2019-07-24 22:28:35.690 7f21573fcb40 -1 monclient: get_monmap_and_config cannot identify monitors to contact
+  [2]
   $ rbd image-meta remove
   rbd: image name was not specified
   [22]
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/cli/rbd/too-many-args.t: passed
# Ran 4 tests, 0 skipped, 1 failed.
Tests that failed:  rbd
Signed-off-by: songweibin <song.weibin@zte.com.cn>
(cherry picked from commit 3ddec74)
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 4, 2019

@yuriw yuriw merged commit 8d5bb89 into ceph:mimic Oct 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@dillaman dillaman deleted the dillaman:wip-40234-mimic branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.