Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw_file: fix invalidation of top-level directories #29309

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@smithfarm
Copy link
Contributor

commented Jul 25, 2019

rgw_file: permit lookup_handle to lookup root_fh
Originally, root_fh was reachable from RGWLibFS::fh_cache, but
this was problematic as it has infinite lifetime and so is not
present in RGWLibFS::fs_lru.

To fix the above, RGWLibFS::root_fh came to live unhooked from the
handle caches which works because nfs-ganesha/the application
always has an instance handle.  However, this silently breaks
READDIR event invalidation.

Fixes: https://tracker.ceph.com/issues/40196

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 547cb9f)

@smithfarm smithfarm self-assigned this Jul 25, 2019

@smithfarm smithfarm added this to the nautilus milestone Jul 25, 2019

@smithfarm smithfarm requested a review from mattbenjamin Jul 25, 2019

@smithfarm smithfarm added rgw and removed core labels Jul 25, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

@mattbenjamin @chardan Same build errors here in the nautilus backport as seen in the mimic backport :-(

rgw_file: pretty-print fh_key
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 84a2c22)
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@mattbenjamin
Copy link
Contributor

left a comment

looks good

@yuriw yuriw merged commit 1db19cd into ceph:nautilus Aug 1, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-40216-nautilus branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.