Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw/OutputDataSocket: append_output(buffer::list&) says it will (but does not) discard output at data_max_backlog #29310

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@smithfarm
Copy link
Contributor

commented Jul 25, 2019

rgw/OutputDataSocket: actually discard data on full buffer
A dout message in OutputDataSocket::append_output() states that
data will be dropped when appending would cause data_max_backlog
to be exceeded--but the method appends it anyway.

Log output discards at level 0, as messages will be lost.  Suppress
repeated warnings mod 100.  Switch to vector.

Fixes: http://tracker.ceph.com/issues/40178

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit c806b82)

@smithfarm smithfarm self-assigned this Jul 25, 2019

@smithfarm smithfarm added this to the nautilus milestone Jul 25, 2019

@smithfarm smithfarm added bug fix core rgw and removed core labels Jul 25, 2019

@smithfarm smithfarm requested review from mattbenjamin, cbodley and dang Jul 25, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@yuriw yuriw merged commit 2534e4a into ceph:nautilus Jul 30, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-40349-nautilus branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.