Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw: multisite: 'radosgw-admin bilog trim' stops after 1000 entries #29326

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@smithfarm
Copy link
Contributor

commented Jul 25, 2019

cls/rgw: keep issuing bilog trim ops after reset
The CLSRGWIssueBILogTrim class is intended to keep submitting
cls_log_trim operations on each bucket index shard until they return
-ENODATA to signal there's no more to trim.

However, if the while loop in CLSRGWConcurrentIO::operator() gets to the
end of the shard list and collects all of its completions,
wait_for_completions() will return false and exit the loop. This is
always the case when num_shards = 1.

Fixes: http://tracker.ceph.com/issues/40187

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit a6ea843)

@smithfarm smithfarm self-assigned this Jul 25, 2019

@smithfarm smithfarm added this to the nautilus milestone Jul 25, 2019

@smithfarm smithfarm added bug fix core rgw and removed core labels Jul 25, 2019

@smithfarm smithfarm changed the title nautilus: multisite: 'radosgw-admin bilog trim' stops after 1000 entries nautilus: rgw: multisite: 'radosgw-admin bilog trim' stops after 1000 entries Jul 25, 2019

@smithfarm smithfarm requested a review from cbodley Jul 25, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@yuriw yuriw merged commit fb230f0 into ceph:nautilus Aug 18, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-40540-nautilus branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.