Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: Pool graph/sparkline points do not display the correct values #29352

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@Devp00l
Copy link
Contributor

commented Jul 26, 2019

@Devp00l Devp00l self-assigned this Jul 26, 2019

@Devp00l Devp00l added this to the nautilus milestone Jul 26, 2019

@Devp00l Devp00l requested review from votdev and alfonsomthd Jul 26, 2019

@Devp00l Devp00l changed the title nautilus: mgr/dashboard: Pool graph/sparkline points do not display the correct values mgr/dashboard: Pool graph/sparkline points do not display the correct values Aug 1, 2019

@Devp00l

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

jenkins test dashboard

@Devp00l Devp00l changed the title mgr/dashboard: Pool graph/sparkline points do not display the correct values nautilus: mgr/dashboard: Pool graph/sparkline points do not display the correct values Aug 1, 2019

@Devp00l Devp00l requested a review from tspmelo Aug 2, 2019

@tspmelo

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

jenkins test dashboard

2 similar comments
@tspmelo

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

jenkins test dashboard

@tspmelo

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

jenkins test dashboard

mgr/dashboard: Pool list shows current r/w byte usage in graph
Now the pool list will show the current read and write byte usage in the
sparkline graph like it is already done in the OSD listing.

Fixes: https://tracker.ceph.com/issues/39650
Signed-off-by: Stephan Müller <smueller@suse.com>
(cherry picked from commit 2f18cf5)

 Conflicts (trivial):
	src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.spec.ts

@Devp00l Devp00l force-pushed the Devp00l:wip-40658-nautilus branch from d886f41 to 87618cc Aug 13, 2019

@LenzGr
LenzGr approved these changes Aug 15, 2019
Copy link
Contributor

left a comment

LGTM!

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@yuriw yuriw merged commit d47090e into ceph:nautilus Aug 18, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.