Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: Fix the table mouseenter event handling test #29354

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@Devp00l
Copy link
Contributor

commented Jul 26, 2019

@Devp00l Devp00l self-assigned this Jul 26, 2019

@Devp00l Devp00l added this to the nautilus milestone Jul 26, 2019

@Devp00l Devp00l requested review from tspmelo and callithea Jul 26, 2019

@callithea
Copy link
Member

left a comment

lgtm

@callithea
Copy link
Member

left a comment

the mgr-dashboard-frontend-unittests failed, can you please take a look?

mgr/dashboard: Fix the table mouseenter event handling test
This test only failed if all suites were run, for some reason the window
object got replaced with a mock window. The workaround is not to use
the window object, but mock the called function in order to call the
values as expected by window.

Fixes: https://tracker.ceph.com/issues/40580
Signed-off-by: Stephan Müller <smueller@suse.com>
(cherry picked from commit efc7999)

Conflicts (trivial + linting issue):
	src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.spec.ts

@Devp00l Devp00l force-pushed the Devp00l:wip-40982-nautilus branch from 8ef3369 to b15077d Jul 30, 2019

@Devp00l

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

jenkins test dashboard

1 similar comment
@tspmelo

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

jenkins test dashboard

@Devp00l Devp00l requested a review from callithea Aug 12, 2019

@Devp00l Devp00l requested a review from ceph/dashboard Aug 12, 2019

@Devp00l Devp00l requested a review from ceph/dashboard Aug 13, 2019

@LenzGr
LenzGr approved these changes Aug 15, 2019
Copy link
Contributor

left a comment

LGTM.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@smithfarm smithfarm removed the needs-review label Aug 16, 2019

@yuriw yuriw merged commit 2f03cb2 into ceph:nautilus Aug 18, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.