Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: osd/PG: do not queue scrub if PG is not active when unblock #29372

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@pdvian
Copy link

commented Jul 29, 2019

osd/PG: do not queue scrub if PG is not active when unblock
- we are scrubbing
- we block scrub on an object
- we have an interval reset on epoch X
- we unblock and queue scrub in epoch X
- we finish the reset (we are no longer scrubbing)
- we process the PGScrub on epoch X, it is still epoch X, and we are not
  scrubbing
  -> assert

Fix by not queueing scrub if we are unblocking and the PG is no longer
active (because we are mid-way through the peering reset).

Fixes: http://tracker.ceph.com/issues/40451
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 7a3227e)

@tchaikov tchaikov added this to the nautilus milestone Jul 29, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@yuriw yuriw merged commit 99be48e into ceph:nautilus Aug 15, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.