Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs-shell: Fix multiple flake8 errors #29374

Merged
merged 5 commits into from Jul 29, 2019

Conversation

@varshar16
Copy link
Contributor

varshar16 commented Jul 29, 2019

After ignoring line break before binary operator (W503) flake8 errors and limiting line length to 100. This patch series fixes the following errors:

[root@localhost ceph]# flake8 --ignore=W503 --max-line-length=100 src/tools/cephfs/cephfs-shell
cephfs-shell:80:28: E241 multiple spaces after ':'
cephfs-shell:171:47: E226 missing whitespace around arithmetic operator
cephfs-shell:185:101: E501 line too long (101 > 100 characters)
cephfs-shell:770:64: W504 line break after binary operator
cephfs-shell:771:37: W504 line break after binary operator
cephfs-shell:772:36: W504 line break after binary operator
cephfs-shell:776:57: W504 line break after binary operator
cephfs-shell:777:54: W504 line break after binary operator
cephfs-shell:778:40: W504 line break after binary operator
cephfs-shell:779:39: W504 line break after binary operator
cephfs-shell:1070:48: E226 missing whitespace around arithmetic operator
cephfs-shell:1074:40: E226 missing whitespace around arithmetic operator
cephfs-shell:1226:37: E226 missing whitespace around arithmetic operator
cephfs-shell:1242:19: E126 continuation line over-indented for hanging indent
cephfs-shell:1289:44: E226 missing whitespace around arithmetic operator
@varshar16 varshar16 force-pushed the varshar16:wip-cephfs-shell-flake8-errors branch from bef0e4f to 98f3691 Jul 29, 2019
@batrick batrick merged commit 98f3691 into ceph:master Jul 29, 2019
4 of 5 checks passed
4 of 5 checks passed
make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
batrick added a commit that referenced this pull request Jul 29, 2019
* refs/pull/29374/head:
	cephfs-shell: Fix flake8 line too long error
	cephfs-shell: Fix flake8 line break after binary operator error
	cephfs-shell: Fix flake8 continuation line over-indented for hanging indent error
	cephfs-shell: Fix flake8 missing whitespace around arithmetic operator error
	cephfs-shell: Fix multiple spaces after ':' flake8 error

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
@varshar16 varshar16 deleted the varshar16:wip-cephfs-shell-flake8-errors branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.