Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw_file: fix readdir eof() calc--caller stop implies !eof #29409

Merged
merged 1 commit into from Aug 18, 2019

Conversation

rgw_file: fix readdir eof() calc--caller stop implies !eof
If rgw_readdir2()'s caller stops enumeration by returning an error
from the readdir callback function, the value of eof is false
for the rgw_readdir2() call.  I.e., eof() is true when the
underlying listing is !truncated and no results were refused by
the caller.

Fixes: http://tracker.ceph.com/issues/40375

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 7fa9cf3)

@tchaikov tchaikov added this to the nautilus milestone Jul 31, 2019

@smithfarm smithfarm requested a review from mattbenjamin Aug 15, 2019

@smithfarm smithfarm added the rgw label Aug 15, 2019

@smithfarm smithfarm requested a review from cbodley Aug 15, 2019

@mattbenjamin
Copy link
Contributor

left a comment

looks good

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@yuriw yuriw merged commit 4003b6e into ceph:nautilus Aug 18, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.