Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: simple: when 'type' file is not present activate fails #29417

Merged
merged 3 commits into from Aug 7, 2019

Conversation

@jan--f
Copy link
Member

jan--f commented Jul 31, 2019

alfredodeza added 2 commits Jul 29, 2019
…pe is not found

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit b6a449e)
…e detection

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit e48ad3a)
@jan--f jan--f self-assigned this Jul 31, 2019
@jan--f jan--f added this to the mimic milestone Jul 31, 2019
@jan--f jan--f requested a review from alfredodeza Jul 31, 2019
@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Aug 5, 2019

jenkins test ceph-volume tox

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Aug 5, 2019

Seems like we are hitting valid failures, but those are not related to this PR:

_____ TestMixedTypeWithExplicitDevices.test_wal_device_is_not_large_enough _____

self = <ceph_volume.tests.devices.lvm.strategies.test_bluestore.TestMixedTypeWithExplicitDevices object at 0x7f7e0959d978>
stub_vgs = <function stub_vgs.<locals>.apply at 0x7f7e0958f510>
fakedevice = <function fakedevice.<locals>.apply at 0x7f7e0958f2f0>
factory = <class 'ceph_volume.tests.conftest.Factory'>
conf_ceph = <function conf_ceph.<locals>.apply at 0x7f7e0958f598>

    def test_wal_device_is_not_large_enough(self, stub_vgs, fakedevice, factory, conf_ceph):
        conf_ceph(get_safe=lambda *a: None)
        args = factory(filtered_devices=[], osds_per_device=2,
                       block_db_size=None, block_wal_size=None,
                       osd_ids=[])
        ssd = fakedevice(used_by_ceph=False, is_lvm_member=False, rotational=False, sys_api=dict(size=1610612736))
        hdd = fakedevice(used_by_ceph=False, is_lvm_member=False, rotational=True, sys_api=dict(size=60073740000))
    
        with pytest.raises(RuntimeError) as error:
            bluestore.MixedType(args, [hdd], [], [ssd]).computed['osds'][0]
        expected = 'Unable to use device 1.50 GB /dev/sda, LVs would be smaller than 1GB'
>       assert expected in str(error), str(error)
E       AssertionError: <ExceptionInfo RuntimeError tblen=5>
E       assert 'Unable to use device 1.50 GB /dev/sda, LVs would be smaller than 1GB' in '<ExceptionInfo RuntimeError tblen=5>'
E        +  where '<ExceptionInfo RuntimeError tblen=5>' = str(<ExceptionInfo RuntimeError tblen=5>)

That type of assertion check on exceptions is no longer allowed in newer pytest versions. It recently changed. It was fixed with this PR #28866 which I guess it needs to be backported

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Aug 6, 2019

There are some odd errors with the tests, the assertion error is known and has a fix already. I am fine if you want to wait for the backports or move forward with this one @jan--f

@jan--f

This comment has been minimized.

Copy link
Member Author

jan--f commented Aug 6, 2019

@alfredodeza I'll look into the backports...will let you know.

This fixes a backported test that was not fixed on a backport. Original
fix: #28948. Backport:
#29243.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
@jan--f

This comment has been minimized.

Copy link
Member Author

jan--f commented Aug 6, 2019

Yeah I made a mistake in a backport. https://github.com/ceph/ceph/pull/29243/files#diff-78f0a822e775d7f8a95fe8c16917df32R202

Will add a fix here.

@jan--f

This comment has been minimized.

Copy link
Member Author

jan--f commented Aug 6, 2019

jenkins test ceph-volume tox

@jan--f

This comment has been minimized.

Copy link
Member Author

jan--f commented Aug 7, 2019

tox only fails on a flake8 error.

@jan--f jan--f merged commit 505297c into ceph:mimic Aug 7, 2019
4 of 5 checks passed
4 of 5 checks passed
ceph-volume tox testing ceph-volume tox failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@jan--f jan--f deleted the jan--f:wip-41022-mimic branch Aug 7, 2019
@smithfarm smithfarm changed the title mimic: simple: when 'type' file is not present activate fails mimic: ceph-volume: simple: when 'type' file is not present activate fails Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.