Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rocksdb: rocksdb_rmrange related improvements #29439

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@neha-ojha
Copy link
Member

commented Jul 31, 2019

Zengran Zhang and others added 2 commits Apr 2, 2019
kv: make delete range optional on number of keys
Actually, we may only wanna let the objects with real big number of omap to
use delete range. if not, we find too many tombstones will have side-effects
on performance of kv.

refer: https://github.com/facebook/rocksdb/wiki/DeleteRange-Implementation

Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>
(cherry picked from commit b039e63)
rocksdb: enable rocksdb_rmrange=true by default
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 07cc884)

@neha-ojha neha-ojha added the core label Jul 31, 2019

@neha-ojha neha-ojha added this to the nautilus milestone Jul 31, 2019

@neha-ojha

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

Ideally, we want to let #29323 bake in master for another week or so, but there is no harm in getting the nautilus backport tested.

@neha-ojha neha-ojha requested review from jdurgin and tchaikov Aug 1, 2019

@jdurgin
jdurgin approved these changes Aug 1, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@yuriw yuriw merged commit 5f40d87 into ceph:nautilus Aug 12, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@neha-ojha neha-ojha deleted the neha-ojha:wip-40969-nautilus branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.