Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rocksdb: Updated to v6.1.2 #29440

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@neha-ojha
Copy link
Member

commented Aug 1, 2019

Fixes: https://tracker.ceph.com/issues/40940

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
rocksdb: Updated to v6.1.2
Signed-off-by: Mark Nelson <mnelson@redhat.com>
(cherry picked from commit 5143607)

@neha-ojha neha-ojha added the core label Aug 1, 2019

@neha-ojha neha-ojha added this to the nautilus milestone Aug 1, 2019

@neha-ojha

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Ideally, we want to let #29440 bake in master for another week or so, but there is no harm in getting the nautilus backport tested.

@neha-ojha neha-ojha requested review from markhpc and jdurgin Aug 1, 2019

@jdurgin
jdurgin approved these changes Aug 1, 2019

@neha-ojha neha-ojha added the needs-qa label Aug 1, 2019

@markhpc

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Looks like v6.1.2 has baked in master for a week without ill effect. If Josh is ok with backporting at this point I can get behind it. I think the only question is if we are going to want to backport again to pick up 6.3.0 when it comes out (so we don't need the cmake fix cherry-pick) or to pick up any potential changes from Igor regarding bluefs file placement hints.

@markhpc
markhpc approved these changes Aug 1, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@yuriw yuriw merged commit 1fd0f60 into ceph:nautilus Aug 12, 2019

3 of 4 checks passed

Unmodified Submodules Approval needed: modified submodules found
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
make check make check succeeded
Details

@neha-ojha neha-ojha deleted the neha-ojha:wip-40940-nautilus branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.