Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: ceph-volume: does not recognize wal/db partitions created by ceph-disk #29463
This adds a parameterized fixture as input to the tests. Should make writing new tests easier since only fixture parameters need to be added. In the future we should be able to reuse the fixtures to build other fixtures and reuse the parametrization. Signed-off-by: Jan Fajerski <email@example.com> (cherry picked from commit f42287c)
In some cases ceph-disk does not populate PARTLABEL for wal and db partitions. This commit adds the assumption that the empty string is a valid label and falls back to identifying those disks by PARTTYPE. Fixes: https://tracker.ceph.com/issues/40917 Signed-off-by: Jan Fajerski <firstname.lastname@example.org> (cherry picked from commit 82d2ae7)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.