rgw_file: readdir: do not construct markers w/leading '/' #29670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case arises when listing the top directory of a bucket, and, with proper continued enumeration, would generate a non-terminating loop if a directory contained names which sort lexically before '/'. Fixes: https://tracker.ceph.com/issues/41252 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
dang
approved these changes
Aug 14, 2019
cbodley
reviewed
Aug 15, 2019
| } | ||
| path += *s; | ||
| ++pos; |
There was a problem hiding this comment.
i'm having trouble understanding this change from bool first to int pos; are the two not logically equivalent?
There was a problem hiding this comment.
I staged and reverted a change here, which needed to look past first position. I decided that this logic is preferable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case arises when listing the top directory of a bucket, and,
with proper continued enumeration, would generate a non-terminating
loop if a directory contained names which sort lexically before '/'.
Fixes: https://tracker.ceph.com/issues/41252
Signed-off-by: Matt Benjamin mbenjamin@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test docsjenkins render docs