Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: core: Better default value for osd_snap_trim_sleep #29678

Merged
merged 3 commits into from Aug 19, 2019

Conversation

neha-ojha added 3 commits Jun 26, 2019
osd: add hdd, ssd and hybrid variants for osd_snap_trim_sleep
This is better than the earlier default, which was set to 0.

Fixes: https://tracker.ceph.com/issues/40528
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 560fca1)

Conflicts:
	src/osd/OSD.cc : Resolved for get_osd_snap_trim_sleep
doc/rados/configuration/osd-config-ref.rst: document snap trim sleep
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit accf95e)
common/options.cc, doc: osd_snap_trim_sleep overrides other variants
A value > 0 for osd_snap_trim_sleep, will override the backend specific
variants of osd_snap_trim_sleep.

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 733df09)

@tchaikov tchaikov added this to the nautilus milestone Aug 15, 2019

@smithfarm smithfarm changed the title nautilus: Better default value for osd_snap_trim_sleep nautilus: core: Better default value for osd_snap_trim_sleep Aug 16, 2019

@smithfarm smithfarm requested a review from neha-ojha Aug 16, 2019

@smithfarm smithfarm requested review from dzafman and jdurgin Aug 16, 2019

@smithfarm smithfarm removed the needs-qa label Aug 16, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

@yuriw yuriw merged commit 27ff851 into ceph:nautilus Aug 19, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.