Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: ceph-volume: [filestore,bluestore] single type strategies fail after tracking devices as sets #29702

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@jan--f
Copy link
Member

commented Aug 16, 2019

ceph-volume: don't keep device lists as sets
This was introduced by #27754. The explicit device lists were cast to
sets but other parts of the code where not updated accordingly. To avoid
touching all code places, only cast to sets for disjoint test and keep
lists otherwise.

Fixes: https://tracker.ceph.com/issues/41292

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
(cherry picked from commit 0534cf1)

@jan--f jan--f self-assigned this Aug 16, 2019

@jan--f jan--f added this to the nautilus milestone Aug 16, 2019

@jan--f

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

jenkins test ceph-volume all

@jan--f jan--f requested a review from alfredodeza Aug 16, 2019

@smithfarm smithfarm changed the title nautilus: regression: [filestore,bluestore] single type strategies fail after tracking devices as sets nautilus: ceph-volume: [filestore,bluestore] single type strategies fail after tracking devices as sets Aug 16, 2019

@alfredodeza alfredodeza merged commit b07494e into ceph:nautilus Aug 16, 2019

18 of 40 checks passed

ceph-volume batch testing centos7-bluestore-mixed_type ceph-volume batch centos7-bluestore-mixed_type failed
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt ceph-volume batch centos7-bluestore-mixed_type_dmcrypt failed
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-bluestore-mixed_type_dmcrypt_explicit failed
Details
ceph-volume batch testing centos7-filestore-mixed_type ceph-volume batch centos7-filestore-mixed_type failed
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt ceph-volume batch centos7-filestore-mixed_type_dmcrypt failed
Details
ceph-volume batch testing centos7-filestore-single_type ceph-volume batch centos7-filestore-single_type failed
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt ceph-volume batch centos7-filestore-single_type_dmcrypt failed
Details
ceph-volume batch testing xenial-filestore-single_type ceph-volume batch xenial-filestore-single_type failed
Details
ceph-volume lvm testing centos7-filestore-dmcrypt ceph-volume lvm centos7-filestore-dmcrypt failed
Details
ceph-volume lvm testing xenial-filestore-create ceph-volume lvm xenial-filestore-create failed
Details
ceph-volume simple testing centos7-bluestore-activate ceph-volume simple centos7-bluestore-activate failed
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks ceph-volume simple centos7-bluestore-dmcrypt_luks failed
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain ceph-volume simple centos7-bluestore-dmcrypt_plain failed
Details
ceph-volume simple testing centos7-filestore-activate ceph-volume simple centos7-filestore-activate failed
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks ceph-volume simple centos7-filestore-dmcrypt_luks failed
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain ceph-volume simple centos7-filestore-dmcrypt_plain failed
Details
ceph-volume simple testing xenial-bluestore-activate ceph-volume simple xenial-bluestore-activate failed
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks ceph-volume simple xenial-bluestore-dmcrypt_luks failed
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain ceph-volume simple xenial-bluestore-dmcrypt_plain failed
Details
ceph-volume simple testing xenial-filestore-activate ceph-volume simple xenial-filestore-activate failed
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks ceph-volume simple xenial-filestore-dmcrypt_luks failed
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain ceph-volume simple xenial-filestore-dmcrypt_plain failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type_explicit ceph-volume batch centos7-bluestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-bluestore-single_type ceph-volume batch centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt ceph-volume batch centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-filestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_explicit ceph-volume batch centos7-filestore-mixed_type_explicit OK
Details
ceph-volume batch testing xenial-bluestore-single_type ceph-volume batch xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt ceph-volume batch xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt ceph-volume batch xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create ceph-volume lvm centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt ceph-volume lvm centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create ceph-volume lvm centos7-filestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-create ceph-volume lvm xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt ceph-volume lvm xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt ceph-volume lvm xenial-filestore-dmcrypt OK
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.