nautilus: mgr/rbd_support: support scheduling long-running background operations #29725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 026df75)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 361e51f)
This callback can be used to track progress and also to attempt to cancel the operation while it's in-progress by returning a negative error code from the callback. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 6dc8249)
This allows the error to be directly caught instead of attempting to parse the OSError.errno Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 2e85381)
Fixes: http://tracker.ceph.com/issues/40621 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit b7a826d)
The failed events can also include a failure message to indicate the reason for the failure. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit d78ddaa) Conflicts: src/pybind/mgr/progress/module.py: tweaked missing backport for task start/stop times
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit b99ae27)
This dict will include an origin key fixed to 'rbd_support' as well as pool and image references. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit e87aff5)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 63a8f6c)
The 'ceph' CLI will duplicate commands within teuthology to test the MONs idempotency. This shouldn't be required for the MGR module, but we can keep a fixed set of completed tests to handle this possible command replay. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 9bdc376)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 7ccf0b3)
.. should be invoked as self.unregister_osd_perf_queries() rather than self.module.unregister_osd_perf_queries(). Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 37a9b53)
This helps to to avoid the case where new tasks were not being scheduled when an image name was re-used after having a task created under the same name. Fixes: https://tracker.ceph.com/issues/41032 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 7adb17f)
The 'rbd_support' mgr module provides many background functions that are required by the 'rbd' CLI performance queries, as well as future background long-running maintenance tasks. Fixes: http://tracker.ceph.com/issues/40790 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 7231aab) Conflicts: src/mon/MgrMonitor.cc: trivial resolution
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/41078
https://tracker.ceph.com/issues/41275