Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: Better default value for osd_snap_trim_sleep #29732

Merged
merged 3 commits into from Oct 3, 2019

Conversation

neha-ojha added 3 commits Jun 26, 2019
This is better than the earlier default, which was set to 0.

Fixes: https://tracker.ceph.com/issues/40528
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 560fca1)

Conflicts:
	src/osd/PrimaryLogPG.h : Resolved for osd_snap_trim_sleep
	src/osd/OSD.cc : Resolved in get_osd_snap_trim_sleep
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit accf95e)
A value > 0 for osd_snap_trim_sleep, will override the backend specific
variants of osd_snap_trim_sleep.

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 733df09)
@tchaikov tchaikov added this to the mimic milestone Aug 19, 2019
@neha-ojha neha-ojha added the core label Aug 27, 2019
@neha-ojha neha-ojha requested review from neha-ojha and dzafman Aug 27, 2019
Copy link
Member

dzafman left a comment

LGTM

@neha-ojha neha-ojha added the needs-qa label Aug 27, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Sep 8, 2019

jenkins test docs

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Sep 30, 2019

@yuriw yuriw merged commit c12cb3e into ceph:mimic Oct 3, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm changed the title mimic: Better default value for osd_snap_trim_sleep mimic: core: Better default value for osd_snap_trim_sleep Oct 4, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 4, 2019

@neha-ojha @dzafman Does this warrant a release notes entry? Will it catch mimic users by surprise when they upgrade to 13.2.7?

@dzafman

This comment has been minimized.

Copy link
Member

dzafman commented Oct 4, 2019

@smithfarm I'm comfortable without a release note entry. Since snap trim is a background task, users aren't going to notice this change. The benefit is that snap trim will have less impact on client operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.