Skip to content

/ceph

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: ceph daemon mon.a config set mon_health_to_clog false cause leader mon assert #29741

Merged
merged 1 commit into from Oct 3, 2019
Merged

mimic: core: ceph daemon mon.a config set mon_health_to_clog false cause leader mon assert #29741

merged 1 commit into from Oct 3, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Aug 19, 2019

https://tracker.ceph.com/issues/41287
huangjun @smithfarm
mon: take the mon lock in handle_conf_change
Loading status checks…
40fdf48 
Let the finisher thread to do the job, it can hold the mon lock
and not hold the config::lock, so can avoid dead lock with mon::tick thread.

Fixes: http://tracker.ceph.com/issues/39625

Signed-off-by: huangjun <huangjun@xsky.com>
(cherry picked from commit bf57e20)
@smithfarm smithfarm self-assigned this Aug 19, 2019
@smithfarm smithfarm added this to the mimic milestone Aug 19, 2019
@smithfarm smithfarm changed the title mimic: ceph daemon mon.a config set mon_health_to_clog false cause leader mon assert mimic: core: ceph daemon mon.a config set mon_health_to_clog false cause leader mon assert Aug 19, 2019
@smithfarm smithfarm requested review from tchaikov and neha-ojha Aug 19, 2019
@tchaikov
tchaikov approved these changes Aug 19, 2019
View changes
@neha-ojha
neha-ojha approved these changes Aug 19, 2019
View changes
@neha-ojha neha-ojha added the needs-qa label Aug 19, 2019
@yuriw

This comment has been minimized.

Sign in to view
Copy link
Contributor

yuriw commented Sep 30, 2019

wip-yuri3-testing-2019-09-30-1547
@yuriw yuriw merged commit 5b16d48 into ceph:mimic Oct 3, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41287-mimic branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov

@neha-ojha neha-ojha

Assignees

@smithfarm smithfarm

Labels
bug fix core mimic-batch-1 needs-qa wip-yuri3-testing
Projects
None yet
Milestone
  mimic
4 participants
@smithfarm @yuriw @tchaikov @neha-ojha
You can’t perform that action at this time.