nautilus: os/bluestore: do not set osd_memory_target default from cgroup limit #29745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the aarch64 box I'm testing, this gives us a value of 7378697629483768832, which is not what we want. I think we are better off relying on this limit being explicitly set via environment variables (POD_* by kuberentes/rook) or via the command line. This partially reverts 5c6b533, but not all of it, since we wan to keep the option itself, as it is now used by common/config.cc when dealing with the POD_MEMORY_LIMIT env var. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 9346d3c)
jdurgin
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/41455
On the aarch64 box I'm testing, this gives us a value of
7378697629483768832, which is not what we want.
I think we are better off relying on this limit being explicitly set via
environment variables (POD_* by kuberentes/rook) or via the command line.
This partially reverts 5c6b533, but not
all of it, since we wan to keep the option itself, as it is now used by
common/config.cc when dealing with the POD_MEMORY_LIMIT env var.
Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit 9346d3c)