Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: os/bluestore: do not set osd_memory_target default from cgroup limit #29745

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@liewegas
Copy link
Member

commented Aug 19, 2019

https://tracker.ceph.com/issues/41455


On the aarch64 box I'm testing, this gives us a value of
7378697629483768832, which is not what we want.

I think we are better off relying on this limit being explicitly set via
environment variables (POD_* by kuberentes/rook) or via the command line.

This partially reverts 5c6b533, but not
all of it, since we wan to keep the option itself, as it is now used by
common/config.cc when dealing with the POD_MEMORY_LIMIT env var.

Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit 9346d3c)

os/bluestore: do not set osd_memory_target default from cgroup limit
On the aarch64 box I'm testing, this gives us a value of
7378697629483768832, which is not what we want.

I think we are better off relying on this limit being explicitly set via
environment variables (POD_* by kuberentes/rook) or via the command line.

This partially reverts 5c6b533, but not
all of it, since we wan to keep the option itself, as it is now used by
common/config.cc when dealing with the POD_MEMORY_LIMIT env var.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 9346d3c)

@liewegas liewegas added this to the nautilus milestone Aug 19, 2019

@liewegas liewegas requested review from yuriw and jdurgin Aug 19, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

@yuriw
yuriw approved these changes Aug 20, 2019
Copy link
Contributor

left a comment

passed tests 👍

@yuriw yuriw merged commit 4b7bd00 into ceph:nautilus Aug 20, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.