Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: use the OSD identifier when reporting success #29770

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@alfredodeza
Copy link
Contributor

alfredodeza commented Aug 20, 2019

It was otherwise failing to use ID or FSID and reporting None, because Python evaluated the string with the first None as True even when FSID had an actual value.

In [2]: "Successful zap for OSD: %s" % None or "asdf-lkjh"                                                                                                                                                         
Out[2]: 'Successful zap for OSD: None'

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1738379
Backport of: #29762

@alfredodeza alfredodeza added this to the mimic milestone Aug 20, 2019
alfredodeza added 2 commits Aug 20, 2019
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 88c7429)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit d0d5750)
@alfredodeza alfredodeza force-pushed the alfredodeza:mimic-bz-1738379 branch from 8bb4162 to b76f096 Aug 20, 2019
@jan--f
jan--f approved these changes Aug 21, 2019
Copy link
Member

jan--f left a comment

LGTM, failures are cluster not coming up.

@alfredodeza alfredodeza merged commit 0508aa2 into ceph:mimic Aug 21, 2019
36 of 40 checks passed
36 of 40 checks passed
Docs: build check Docs: failed with errors
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt failed
Details
ceph-volume simple testing xenial-bluestore-activate failed
Details
ceph-volume tox tests running
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type OK
Details
ceph-volume lvm testing centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain OK
Details
make check make check succeeded
Details
@smithfarm smithfarm changed the title mimic ceph-volume: use the OSD identifier when reporting success mimic: ceph-volume: use the OSD identifier when reporting success Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.