Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: asio: check the remote endpoint before processing requests #29967

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@theanalyst
Copy link
Member

commented Aug 28, 2019

socket.remote_endpoint() can throw exceptions corresponding to errors in the
getpeername syscall, make sure these are handled.

Fixes: https://tracker.ceph.com/issues/40018
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
rgw: asio: check the remote endpoint before processing requests
`socket.remote_endpoint()` can throw exceptions corresponding to errors in the
`getpeername` syscall, make sure these are handled.

Fixes: CVE-2019-10222, https://tracker.ceph.com/issues/40018
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

@theanalyst theanalyst requested a review from cbodley Aug 28, 2019

@cbodley
Copy link
Contributor

left a comment

has been tested and verified internally 👍

@theanalyst theanalyst requested a review from cbodley Aug 28, 2019

@theanalyst theanalyst merged commit 6171399 into ceph:master Aug 28, 2019

3 of 5 checks passed

make check running make check
Details
make check (arm64) Build triggered for merge commit.
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.