Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: osd: make project_pg_history handle concurrent osdmap publish #29976

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@dzafman
Copy link
Member

dzafman commented Aug 28, 2019

https://tracker.ceph.com/issues/38450


The class's osdmap may be updated while we are in our loop. Pass it in
explicitly instead.

Fixes: http://tracker.ceph.com/issues/26970
Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit cfe6ca8)

Correction to this commit required because of separating it from very large pull request.
Needed to include part of 4bc0137 which
changed endmap from const OSDMap& to const OSDMapRef&.

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
The class's osdmap may be updated while we are in our loop.  Pass it in
explicitly instead.

Fixes: http://tracker.ceph.com/issues/26970
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit cfe6ca8)

Correction to this commit required because of separating it from very large pull request.
Needed to include part of 4bc0137 which
changed endmap from const OSDMap& to const OSDMapRef&.
@dzafman dzafman added the core label Aug 28, 2019
@dzafman dzafman added this to the mimic milestone Aug 28, 2019
@dzafman dzafman requested a review from liewegas Aug 28, 2019
@dzafman

This comment has been minimized.

Copy link
Member Author

dzafman commented Aug 28, 2019

@liewegas Please confirm that this Mimic backport makes sense separate from #20469.

@smithfarm smithfarm changed the title osd: make project_pg_history handle concurrent osdmap publish mimic: osd: make project_pg_history handle concurrent osdmap publish Aug 29, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Sep 30, 2019

@yuriw yuriw merged commit fd5d003 into ceph:mimic Oct 3, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@dzafman dzafman deleted the dzafman:wip-38450 branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.