Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: perfcounters: add gc retire counter #30073

Merged
merged 1 commit into from Oct 11, 2019
Merged

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 2, 2019

@smithfarm smithfarm added this to the mimic milestone Sep 2, 2019
@smithfarm smithfarm added the rgw label Sep 2, 2019
@smithfarm smithfarm requested review from mattbenjamin and cbodley Sep 2, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 2, 2019

make check failure is:

Transaction check error:
  file /etc/rpm/macros.python from install of python-rpm-macros-3-32.el7.noarch conflicts with file from package python-devel-2.7.5-80.el7_6.x86_64
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 2, 2019

make check failure tracked at https://tracker.ceph.com/issues/41603

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test make check

src/rgw/rgw_gc.cc Outdated Show resolved Hide resolved
To avoid spam, counter updates are batched with the corresponding log
trim chunks.

Fixes: https://tracker.ceph.com/issues/38251

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 77a8e83)

Conflicts:
	src/rgw/rgw_common.h
	src/rgw/rgw_gc.cc
	src/rgw/rgw_perf_counters.cc
	src/rgw/rgw_perf_counters.h
- no "rgw_perf_counters.{cc,h}" in mimic; made the changes in rgw_common.{cc,h}
  instead
@smithfarm smithfarm force-pushed the smithfarm:wip-40517-mimic branch from 32cfd42 to addb0a0 Oct 1, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 4, 2019

@yuriw yuriw merged commit 4051297 into ceph:mimic Oct 11, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40517-mimic branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.