Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: cls/rgw: keep issuing bilog trim ops after reset #30074

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 2, 2019

The CLSRGWIssueBILogTrim class is intended to keep submitting
cls_log_trim operations on each bucket index shard until they return
-ENODATA to signal there's no more to trim.

However, if the while loop in CLSRGWConcurrentIO::operator() gets to the
end of the shard list and collects all of its completions,
wait_for_completions() will return false and exit the loop. This is
always the case when num_shards = 1.

Fixes: http://tracker.ceph.com/issues/40187

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit a6ea843)
@smithfarm smithfarm added this to the mimic milestone Sep 2, 2019
@smithfarm smithfarm added the rgw label Sep 2, 2019
@smithfarm smithfarm requested a review from cbodley Sep 2, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 4, 2019

@yuriw yuriw merged commit edf6d9f into ceph:mimic Oct 11, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40539-mimic branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.