Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: rgw_file: fix readdir eof() calc--caller stop implies !eof and introduce fast S3 Unix stats (immutable) #30077
If rgw_readdir2()'s caller stops enumeration by returning an error from the readdir callback function, the value of eof is false for the rgw_readdir2() call. I.e., eof() is true when the underlying listing is !truncated and no results were refused by the caller. Fixes: http://tracker.ceph.com/issues/40375 Signed-off-by: Matt Benjamin <firstname.lastname@example.org> (cherry picked from commit 7fa9cf3)
For objects originating in S3/Swift, it is frequently acceptable to synthesize c/mtime and size stats from meta attributes in the RGW bucket index entry. Synthetic stat behavior is not compatible with mutation of file ownership and permissions via SETATTR. In future, current xattr-based, mutable, Unix stats may be moved to the bucket index. For now, use synthetic stats only when a new option rgw_nfs_s3_fast_attrs is present. Fixes: http://tracker.ceph.com/issues/40456 Signed-off-by: Matt Benjamin <email@example.com> (cherry picked from commit 6bf2786) Conflicts: src/common/options.cc src/pybind/rgw/rgw.pyx src/rgw/rgw_file.cc - no "MkObjResult RGWLibFS::symlink(...)" in mimic
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.