Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw_file: fix readdir eof() calc--caller stop implies !eof and introduce fast S3 Unix stats (immutable) #30077

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 2, 2019

If rgw_readdir2()'s caller stops enumeration by returning an error
from the readdir callback function, the value of eof is false
for the rgw_readdir2() call.  I.e., eof() is true when the
underlying listing is !truncated and no results were refused by
the caller.

Fixes: http://tracker.ceph.com/issues/40375

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 7fa9cf3)
@smithfarm smithfarm added this to the mimic milestone Sep 2, 2019
@smithfarm smithfarm added the rgw label Sep 2, 2019
@smithfarm smithfarm requested review from mattbenjamin and cbodley Sep 2, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test make check

For objects originating in S3/Swift, it is frequently acceptable
to synthesize c/mtime and size stats from meta attributes in the RGW
bucket index entry.

Synthetic stat behavior is not compatible with mutation of file
ownership and permissions via SETATTR.  In future, current xattr-based,
mutable, Unix stats may be moved to the bucket index.  For now, use
synthetic stats only when a new option rgw_nfs_s3_fast_attrs is present.

Fixes: http://tracker.ceph.com/issues/40456

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 6bf2786)

Conflicts:
	src/common/options.cc
	src/pybind/rgw/rgw.pyx
	src/rgw/rgw_file.cc
- no "MkObjResult RGWLibFS::symlink(...)" in mimic
@smithfarm smithfarm changed the title mimic: rgw_file: fix readdir eof() calc--caller stop implies !eof mimic: rgw_file: fix readdir eof() calc--caller stop implies !eof and introduce fast S3 Unix stats (immutable) Sep 8, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 4, 2019

@yuriw yuriw merged commit af17541 into ceph:mimic Oct 11, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40599-mimic branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.