Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: minor optimizations related to class Volumes's use #30096

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@jan--f
Copy link
Member

jan--f commented Sep 3, 2019

Avoid creating of list of LVs in different methods of the same module
and resue them.

Fixes: https://tracker.ceph.com/issues/37490
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit ab3a58e)
Add a test that cofirm that the LVs list was created only once when
calling devices.lvm.listing.list()

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 20d6264)
@jan--f

This comment has been minimized.

Copy link
Member Author

jan--f commented Sep 25, 2019

jenkins test make check

@alfredodeza alfredodeza merged commit 27f9b19 into ceph:mimic Sep 27, 2019
38 of 40 checks passed
38 of 40 checks passed
ceph-volume lvm testing centos7-filestore-create ceph-volume lvm centos7-filestore-create failed
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks ceph-volume simple xenial-bluestore-dmcrypt_luks failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type ceph-volume batch centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt ceph-volume batch centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-bluestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_explicit ceph-volume batch centos7-bluestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-bluestore-single_type ceph-volume batch centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt ceph-volume batch centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type ceph-volume batch centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt ceph-volume batch centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-filestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_explicit ceph-volume batch centos7-filestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-filestore-single_type ceph-volume batch centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt ceph-volume batch centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type ceph-volume batch xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt ceph-volume batch xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type ceph-volume batch xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt ceph-volume batch xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create ceph-volume lvm centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt ceph-volume lvm centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt ceph-volume lvm centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create ceph-volume lvm xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt ceph-volume lvm xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create ceph-volume lvm xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt ceph-volume lvm xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate ceph-volume simple centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks ceph-volume simple centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain ceph-volume simple centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate ceph-volume simple centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks ceph-volume simple centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain ceph-volume simple centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-activate ceph-volume simple xenial-bluestore-activate OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain ceph-volume simple xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate ceph-volume simple xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks ceph-volume simple xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain ceph-volume simple xenial-filestore-dmcrypt_plain OK
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.