Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rbd-mirror: ignore errors relating to parsing the cluster config file #30117

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 3, 2019

backport tracker: https://tracker.ceph.com/issues/41438


backport of #29808 (NOTE: omitted 57e6849, since we don't expect b128929 to be backported, and also omitted 1e8c41e because it's not strictly needed to fix the bug)
parent tracker: https://tracker.ceph.com/issues/41356

this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

k8s/rook is currently starting daemon pods under root using the
"--setuser" CLI optional to drop priviledges. In the case of
rbd-mirror which creates connections to remote clusters via librados,
the default search path for Ceph config files includes
"$home/.ceph/$cluster.conf", which before this change would evaluate
to "/root/.ceph/..." and then fail with a -EPERM since that directory
is not accessible by the dropped priviledges user.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 591fb2b)

Conflicts:
	src/global/global_init.cc
- master has g_conf()-> where mimic does g_conf->
@smithfarm smithfarm added this to the mimic milestone Sep 3, 2019
@smithfarm smithfarm added the rbd label Sep 3, 2019
@smithfarm smithfarm requested a review from dillaman Sep 3, 2019
@smithfarm smithfarm force-pushed the smithfarm:wip-41438-mimic branch 3 times, most recently from 466d98c to 6287126 Sep 4, 2019
Copy link
Contributor

dillaman left a comment

👍

@dillaman dillaman added the bug fix label Sep 4, 2019
@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Sep 4, 2019

jenkins test docs

1 similar comment
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test make check

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 4, 2019

@yuriw yuriw merged commit 0f54652 into ceph:mimic Oct 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41438-mimic branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.