Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: build/ops: install-deps.sh: Remove CR repo #30128

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 4, 2019

This PR fixes the present scourge of "make check" failures in PRs targeting mimic (https://tracker.ceph.com/issues/41603).

backport tracker: https://tracker.ceph.com/issues/41645


backport of #25211
parent tracker: https://tracker.ceph.com/issues/37335

this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

Remove the continuous release repos for CentOS and Virtuozzo 7 as they
should no longer be needed since http://tracker.ceph.com/issues/13997 is
no longer relevant and the newer versions of selinux packages pulled in
by the build system are causing problems for systems without CR repos
enabled.

Fixes: https://tracker.ceph.com/issues/37335

Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit f39d9b7)
@smithfarm smithfarm added this to the mimic milestone Sep 4, 2019
@smithfarm smithfarm added the core label Sep 4, 2019
@smithfarm smithfarm changed the title mimic: install-deps.sh: Remove CR repo mimic: build/ops: install-deps.sh: Remove CR repo Sep 4, 2019
@smithfarm smithfarm requested review from tchaikov and badone Sep 4, 2019
@smithfarm smithfarm added build/ops and removed core labels Sep 4, 2019
@smithfarm smithfarm requested a review from alfredodeza Sep 4, 2019
@badone

This comment has been minimized.

Copy link
Contributor

badone commented Sep 4, 2019

There has to be more to this than just that the master commit was not backported. Why would it take 10 months for this to show up? Having said that, since the backport should have been done originally (my fault it wasn't) I don't have a problem with it.

@badone
badone approved these changes Sep 4, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 4, 2019

@badone The problem that just showed up is not the same as the one this fix was intended to address 10 months ago. Read https://tracker.ceph.com/issues/41603 for details, but AFAICT tl;dr is that python-rpm-macros just got moved out of CR into the base distro.

@badone

This comment has been minimized.

Copy link
Contributor

badone commented Sep 4, 2019

ack

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 5, 2019

jenkins test submodules

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 5, 2019

jenkins test docs

@smithfarm smithfarm merged commit 5b36a95 into ceph:mimic Sep 5, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41645-mimic branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.