Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: swift: refrain from corrupting static large objects when using nginx as a GET cache #30135

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 4, 2019

@smithfarm smithfarm added this to the mimic milestone Sep 4, 2019
@smithfarm smithfarm added the rgw label Sep 4, 2019
@smithfarm smithfarm changed the title mimic: rgw: swift: bugfix: https://tracker.ceph.com/issues/37765 mimic: rgw: swift: refrain from corrupting static large objects when using nginx as a GET cache Sep 4, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test submodules

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test make check

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/include/Context.h:19:0,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_rados.h:10,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_op.cc:24:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_op.cc: In lambda function:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/dout.h:101:61: error: 'class RGWGetObj' has no member named 'get_subsys'; did you mean 'get_params'?
     dout_impl(dpp->get_cct(), ceph::dout::need_dynamic(dpp->get_subsys()), v)    \
                                                             ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/dout.h:74:51: note: in definition of macro 'dout_impl'
     if constexpr (ceph::dout::is_dynamic<decltype(sub)>::value || \
                                                   ^~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_op.cc:1655:3: note: in expansion of macro 'ldpp_dout'
   ldpp_dout(this, 20) << "Requested: ofs=" << ofs
   ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/dout.h:101:61: error: 'class RGWGetObj' has no member named 'get_subsys'; did you mean 'get_params'?
The meaning is as follows:
iterate_slo_parts() set end offset equal to the size of the segment,
but  RGWRados::iterate_obj args wait offset not size.

Signed-off-by: Andrey Groshev <an.groshev@tensor.ru>
(cherry picked from commit 9cbbd63)

Conflicts:
	src/rgw/rgw_op.cc
- where master has "ldpp_dout(this, X)", mimic uses "ldout(s->cct, X)"
@smithfarm smithfarm force-pushed the smithfarm:wip-41126-mimic branch from f2c1cfc to 14f982b Sep 8, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 8, 2019

jenkins test docs

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 3, 2019

@cbodley
cbodley approved these changes Oct 8, 2019
@yuriw yuriw merged commit 44388c0 into ceph:mimic Oct 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41126-mimic branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.