Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: rgw: Fix bucket versioning vs. swift metadata bug. #30140
When a bucket and object was "versioned", it was not possible to set swift metadata on an existing object. In swift, it is possible to post metadata (stored as extended attributes with specific names) on objects without bumping the version on a versioned object. In ceph, objects in versioned buckets *may* be versioned. Versioned objects have a "olh" (object logical header) header which points to the versioned header which contains or points to the current actual data for the object. Pre-existing logic here correctly sets the attributes for non-versioned objects. For versioned ojbects it incorrectly stored those attributes in the olh rather than in the versioned header. The corrected logic here retains the target object name and stores the attributes in the correct header for both cases rather than in the olh for the versioned object. Fixes: https://tracker.ceph.com/issues/37531 Signed-off-by: Marcus Watts <email@example.com> (cherry picked from commit 70d5e21) Conflicts: src/rgw/rgw_op.cc - function calls take slightly different argument sets in mimic
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.