Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: make dns hostnames matching case insensitive #30166

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 5, 2019

Currently when parsing host in requests, we try to case match against supplied
hostnames set, which violates dns hostnames being case insensitive. Do a case
insensitive comparision instead

Fixes: http://tracker.ceph.com/issues/40995
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 9bc7d7b)
@smithfarm smithfarm added this to the mimic milestone Sep 5, 2019
@smithfarm smithfarm added the rgw label Sep 5, 2019
@smithfarm smithfarm requested a review from cbodley Sep 5, 2019
Copy link
Contributor

cbodley left a comment

i believe this caused a regression, at least for static websites, tracked in https://tracker.ceph.com/issues/41692

Fixes: https://tracker.ceph.com/issues/41692

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 60b2dbe)
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 13, 2019

@cbodley Ready for review

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 3, 2019

@yuriw yuriw merged commit 6ac62d8 into ceph:mimic Oct 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41478-mimic branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.