Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upmimic: rgw: fix potential realm watch lost #30167
Conversation
realm watch only restart on -ENOTCONN, but if we fail to maintain the watch ping, the OSD will return -ETIMEDOUT. The objecter will keep the watch err on last_error, if last_error not empty, it will not call handle_error in future error, so it will never get the chance to rewatch on following -ENOTCONN error. Fixes: http://tracker.ceph.com/issues/40991 Signed-off-by: Tianshan Qu <tianshan@xsky.com> (cherry picked from commit c2d6cbe)
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
smithfarm commentedSep 5, 2019
backport tracker: https://tracker.ceph.com/issues/41483
backport of #29369
parent tracker: https://tracker.ceph.com/issues/40991
this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh