Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rbd: librbd: avoid dereferencing an empty container during deep-copy #30177

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 5, 2019

While updating the image copy progress, a 'while' loop will pop the
last item from the queue and then deference the empty queue.

Fixes: http://tracker.ceph.com/issues/40368
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 0f491cb)
@smithfarm smithfarm added this to the mimic milestone Sep 5, 2019
@smithfarm smithfarm added the rbd label Sep 5, 2019
@smithfarm smithfarm requested review from trociny and dillaman Sep 5, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 7, 2019

jenkins test docs

Copy link
Contributor

dillaman left a comment

👍

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 9, 2019

jenkins test docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 1, 2019

The Docs: build check failure is unrelated to this PR, and addressed by #30663

@smithfarm smithfarm changed the title mimic: librbd: avoid dereferencing an empty container during deep-copy mimic: rbd: librbd: avoid dereferencing an empty container during deep-copy Oct 1, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 4, 2019

@yuriw yuriw merged commit 633c1dc into ceph:mimic Oct 8, 2019
3 of 4 checks passed
3 of 4 checks passed
Docs: build check Docs: failed with errors
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40380-mimic branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.