Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mon/AuthMonitor: fix initial creation of rotating keys #30181

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 5, 2019

liewegas added 2 commits Jul 2, 2019
…s too

Clear the rotating secrets.  And also reset the versions.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit e1600b1)
If we are creating the initial state and initial proposal, start with an
empty keyring.  Specifically, we want to clear out any rotating secrets
from a previously failed paxos round so that the subsequent call to
check_rotate() will correctly populate the initial proposal with new
rotating keys.  (When we don't do this, the leader OSD will have the
keys from an earlier round in memory but no other mons will.)

Fixes: http://tracker.ceph.com/issues/40634
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a346713)
@smithfarm smithfarm added this to the mimic milestone Sep 5, 2019
@smithfarm smithfarm added the core label Sep 5, 2019
@smithfarm smithfarm requested review from tchaikov and neha-ojha Sep 5, 2019
@neha-ojha neha-ojha added the needs-qa label Sep 5, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Sep 30, 2019

@yuriw yuriw merged commit aabe35f into ceph:mimic Oct 3, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-40732-mimic branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.